Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dgw): rework network interface DTO definition #871

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented May 23, 2024

Rework network interface DTO definition for network scan crates and endpoint. As described in Jira ticket.

Issue: DGW-187

@CBenoit
Copy link
Member

CBenoit commented May 24, 2024

Before merging: adjust summary of the commit to match the convention and add the Issue footer to track specify the Jira ticket

@irvingoujAtDevolution irvingoujAtDevolution changed the title [DGW-133]: Rework DTO definition fix(netscan): Rework network interface DTO definition May 24, 2024
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBenoit CBenoit changed the title fix(netscan): Rework network interface DTO definition fix(dgw): rework network interface DTO definition Jun 17, 2024
@CBenoit CBenoit merged commit bc2cb96 into master Jun 17, 2024
20 checks passed
@CBenoit CBenoit deleted the Rework-Interface-Defination branch June 17, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants